Remove radiusOfInnermostHit from tracks
#326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
added a commit
to key4hep/k4FWCore
that referenced
this pull request
Jun 20, 2024
jmcarcell
added a commit
to key4hep/k4SimDelphes
that referenced
this pull request
Jun 20, 2024
jmcarcell
added a commit
to key4hep/k4EDM4hep2LcioConv
that referenced
this pull request
Jun 20, 2024
and compute it from hits when going from EDM4hep to LCIO. See key4hep/EDM4hep#326
jmcarcell
changed the title
radiusOfInnermostHitradiusOfInnermostHit from tracks
|
The fact that this requires changes in |
|
I checked and didn't find anything in FCCAnalyses |
|
OK. Then maybe it was there only temporarily, or we just filled it in k4SimDelphes because we could. Thanks for checking. |
hegner
approved these changes
Jun 24, 2024
|
Perfect. Good we checked this again :) |
|
can we maybe finally fix the release build test environment? Otherwise I am fine with merging |
|
Fixing the release build would require a new Key4hep release. For EDM4hep we could in principle pick up the latest podio tag, but for other packages, we would also need a new EDM4hep tag. I am not sure if we want to make such a tag at the moment. |
tmadlener
pushed a commit
to key4hep/k4SimDelphes
that referenced
this pull request
Jun 26, 2024
see key4hep/EDM4hep#326 Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com>
tmadlener
pushed a commit
to key4hep/k4EDM4hep2LcioConv
that referenced
this pull request
Jun 28, 2024
and compute it from hits when going from EDM4hep to LCIO. See key4hep/EDM4hep#326
tmadlener
force-pushed
the
remove-radius-innermosthit
branch
from
0b08295 to
b452236
Compare
tmadlener
pushed a commit
to key4hep/k4EDM4hep2LcioConv
that referenced
this pull request
Jul 2, 2024
and compute it from hits when going from EDM4hep to LCIO. See key4hep/EDM4hep#326
tmadlener
added a commit
to key4hep/k4EDM4hep2LcioConv
that referenced
this pull request
Jul 3, 2024
* Don't use radiusOfInnermostHit for EDM4hep tracks and compute it from hits when going from EDM4hep to LCIO. See key4hep/EDM4hep#326 * Introdue utility function to determine radius of innermost hit * Add documentation about radius calculation --------- Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: tmadlener <thomas.madlener@desy.de>
tmadlener
force-pushed
the
remove-radius-innermosthit
branch
3 times, most recently
from
773d126 to
b6f2317
Compare
tmadlener
force-pushed
the
remove-radius-innermosthit
branch
from
b6f2317 to
096740e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #319.
Changes in other repos:
radiusOfInnermostHitfrom EDM4hep tracks k4FWCore#202BEGINRELEASENOTES
radiusOfInnermostHitfrom tracksENDRELEASENOTES