Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace link to local file with link to github #101

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

m-fila
Copy link
Contributor

@m-fila m-fila commented Dec 13, 2024

BEGINRELEASENOTES

  • Replaced link to local file with link to github, so the page build correctly in keyhep documentation

ENDRELEASENOTES

Links to local files are replaced with links to github as the documentation page is included in the main key4hep documentation where that local files are not present. key4hep/key4hep-doc#78

doc/LCIO2EDM4hep.md Outdated Show resolved Hide resolved
doc/LCIO2EDM4hep.md Outdated Show resolved Hide resolved
Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
@@ -20,7 +20,7 @@ conversion tool for LCIO to EDM4hep.

## Build and install

If you have an environment that fulfills all dependencies (e.g. a Key4hep stack), simply do
If you have an environment that fulfils all dependencies (e.g. a Key4hep stack), simply do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah UK vs US spelling. I'm not sure which one we use around.

doc/LCIO2EDM4hep.md Outdated Show resolved Hide resolved
@jmcarcell jmcarcell enabled auto-merge (squash) December 17, 2024 10:18
@jmcarcell jmcarcell merged commit 21dd2b2 into key4hep:main Dec 17, 2024
6 checks passed
@m-fila m-fila deleted the broken_links branch December 17, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants