-
Notifications
You must be signed in to change notification settings - Fork 11
Optimize standalone printout #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let me know when you think this is ready. |
33be539
to
4c38391
Compare
4c38391
to
779a8bf
Compare
8200ae8
to
43aee10
Compare
43aee10
to
d59a515
Compare
Ready? I don't know what happened to the Ubuntu test, I was sure it passed before I fixed my missing pre-commit formatting stuff... :( |
Did you try to have copilot explain the error? |
The test failures in Pull Request #107 of the
Recommendations for Fixing the Issues
Would you like further assistance with debugging any specific part of this failure? |
That has been failing since building on ubuntu24 was added. I'll try to have a look but feel free to ignore for this PR. |
Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
int percEvt = i * 100 / (nEvt - 1); | ||
if (percEvt % 10 == 0) { | ||
std::cout << "processed amount of events: " << percEvt << "% (event: " << i << ")" << std::endl; | ||
if ((i + 1) % tenPercent == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If nEvt < 10
then tenPercent
is zero and % 0
can't be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ((i + 1) % tenPercent == 0) { | |
if (tenPercent && ((i + 1) % tenPercent == 0)) { |
BEGINRELEASENOTES
ENDRELEASENOTES
fixes #106
I hope?WARNING: I did not test this yettested :)
new output: