Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce namespace for EDM4hep to LCIO conversion #27

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Sep 12, 2023

BEGINRELEASENOTES

  • Introduce the EDM4hep2LCIOConv namespace for the EDM4hep to LCIO conversion functionality to avoid polluting the global namespace with too many (rather generically named) symbols.
  • Define a EDM4HEP2LCIOCONV_NAMESPACE preprocessor "symbol" that allows downstream users to make for a slightly smoother transition.

ENDRELEASENOTES

Splitting this off of #21 to not have an even more noisy diff there.

Namespace introduction and subsequent formatting are on two separate commits for cleaner blames.

@jmcarcell jmcarcell merged commit 2e6f6c3 into key4hep:main Sep 12, 2023
@tmadlener tmadlener deleted the namespaced-conversion branch September 12, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants