Remove the unnecessary universal reference (#271)

The frame is move only in any case
key4hep · Dec 20, 2024 · 6340086 · 6340086
1 parent 3794b10
commit 6340086
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/k4FWCore/components/MetadataSvc.cpp b/k4FWCore/components/MetadataSvc.cpp
@@ -45,6 +45,6 @@ StatusCode MetadataSvc::finalize() { return Service::finalize(); }
 
 const podio::Frame* MetadataSvc::getFrame() const { return m_frame.get(); }
 podio::Frame*       MetadataSvc::getFrame() { return m_frame.get(); }
-void MetadataSvc::setFrame(podio::Frame&& frame) { m_frame = std::make_unique<podio::Frame>(std::move(frame)); }
+void MetadataSvc::setFrame(podio::Frame frame) { m_frame = std::make_unique<podio::Frame>(std::move(frame)); }
 
 DECLARE_COMPONENT(MetadataSvc)
diff --git a/k4FWCore/components/MetadataSvc.h b/k4FWCore/components/MetadataSvc.h
@@ -42,7 +42,7 @@ class MetadataSvc : public extends<Service, IMetadataSvc> {
 
   const podio::Frame* getFrame() const override;
   podio::Frame*       getFrame() override;
-  void                setFrame(podio::Frame&& frame) override;
+  void                setFrame(podio::Frame frame) override;
 };
 
 #endif
diff --git a/k4FWCore/include/k4FWCore/IMetadataSvc.h b/k4FWCore/include/k4FWCore/IMetadataSvc.h
@@ -29,7 +29,7 @@ class IMetadataSvc : virtual public IInterface {
 public:
   DeclareInterfaceID(IMetadataSvc, 1, 0);
 
-  virtual void setFrame(podio::Frame&& frame) = 0;
+  virtual void setFrame(podio::Frame frame) = 0;
 
   template <typename T> void put(const std::string& name, const T& obj) {
     if (!getFrame()) {