Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run clic reco tests concurrently #106

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Make it possible to run clic reco tests concurrently, by ensuring that cloning the CLICPerformance repository is not done concurrently by several test processes.
  • Only get the last commit of CLICPerformance to speed up the cloning.

ENDRELEASENOTES

Copy link
Collaborator

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if FetchContent would be better to clone the clicperformance repo. But this let's one still run the scripts standalone as well.

@andresailer andresailer merged commit 9ef24c4 into key4hep:master Jan 16, 2023
@tmadlener
Copy link
Contributor Author

Ah, I hadn't even thought about FetchContent tbh. I figured the script would be the easiest solution to only fetch when necessary, i.e. when actually running the tests (instead of at configuration time with FetchContent).

@tmadlener tmadlener deleted the concurrent-tests branch January 16, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants