Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDM4hep <--> LCIO converters #26

Merged
merged 94 commits into from
Apr 26, 2021

Conversation

fdplacido
Copy link
Contributor

@fdplacido fdplacido commented Feb 5, 2021

BEGINRELEASENOTES

  • Implement EDM4hep to LCIO converter on the fly
  • Add LCIO to EDM4hep converter on the fly through k4LCIOReader
  • Gaudi Tools to be added to Algorithms on demand on options file
  • Added testing for EDM4hep -> LCIO conversion and EDM4hep -> LCIO -> EDM4hep conversion, creating the collections artificially, in place.
  • Changed testing to get input files from HTTP key4hep
  • Added documentation on usage of converters. Updated documentation.

ENDRELEASENOTES

@fdplacido fdplacido requested a review from andresailer February 5, 2021 15:34
k4MarlinWrapper/src/components/EDM4hep2Lcio.cpp Outdated Show resolved Hide resolved
k4MarlinWrapper/src/components/MarlinProcessorWrapper.cpp Outdated Show resolved Hide resolved
test/gaudi_opts/test_edm4hep2lcio.py Outdated Show resolved Hide resolved
k4MarlinWrapper/src/components/MarlinProcessorWrapper.cpp Outdated Show resolved Hide resolved
k4MarlinWrapper/src/components/EDM4hep2Lcio.cpp Outdated Show resolved Hide resolved
k4MarlinWrapper/src/components/EDM4hep2Lcio.cpp Outdated Show resolved Hide resolved
@andresailer
Copy link
Collaborator

andresailer commented Feb 11, 2021

Adding conversion from LCIO back to EDM4hep

  • allow configuring which collections to transform. Can use the Conversion parameter and have 'lcio::...' as the first entry in the field to indicate the conversion is going the other way. Or adding a second parameter, in which case maybe Conversion should be renamed and edm4hep:: or lcio:: wouldn't be needed.
  • Storing the output edm4hep collections in the podio/edm4hep file.
  • Calls to the k4LCIOReader conversion functionality

@fdplacido
Copy link
Contributor Author

There is an initial version of the converter back from LCIO to EDM4hep using k4LCIOReader. Note that this PR: key4hep/k4LCIOReader#9 needs to be merged for the converter to be able to access the converter.

@fdplacido fdplacido changed the title [WIP] EDM4hep <--> LCIO converters EDM4hep <--> LCIO converters Apr 19, 2021
@fdplacido fdplacido requested a review from andresailer April 19, 2021 16:03
@fdplacido fdplacido merged commit 5029e2a into key4hep:master Apr 26, 2021
@fdplacido fdplacido deleted the plfernan_edm4hep2lcio branch January 19, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants