Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Make it possible to set the random seed from the options file #52

Merged
merged 13 commits into from
Apr 5, 2022
Merged

[WIP] Make it possible to set the random seed from the options file #52

merged 13 commits into from
Apr 5, 2022

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Nov 16, 2021 •
edited by fdplacido
Loading

BEGINRELEASENOTES

  • Make it possible to set the random seed that is used for the ProcessorEventSeeder of the Marlin processors from the options file by retrieving it from Gaudis Random Service. Fixes Allow to set the randomseed via parameter (or something) #38
  • Use argparse for handling arguments in converter script
  • Cleanup testing of --num-events handling and EOF.

ENDRELEASENOTES

@fdplacido
Copy link
Contributor

The test to check input and output number of events was not writing output.
Needs rebase from master.

@fdplacido
Copy link
Contributor

Check: https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1321

@fdplacido fdplacido requested a review from andresailer March 29, 2022 14:51
@fdplacido
Copy link
Contributor

Needs Gaudi v36r5 in the stack

@fdplacido fdplacido added the needs external PR It needs merged changes from external repositories label Mar 29, 2022
@fdplacido fdplacido removed the needs external PR It needs merged changes from external repositories label Apr 5, 2022
@fdplacido fdplacido merged commit 539404c into key4hep:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdplacido fdplacido fdplacido left review comments

@andresailer andresailer Awaiting requested review from andresailer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to set the randomseed via parameter (or something)
2 participants
@tmadlener @fdplacido