Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaking LCEvent every loop #95

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Fix leaking LCEvent every loop #95

merged 1 commit into from
Nov 24, 2022

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Fix memory leak in LcioEvent, where the event read from file was leaked every event.

ENDRELEASENOTES

@tmadlener tmadlener mentioned this pull request Nov 23, 2022
Closed
@andresailer
Copy link
Collaborator

Seems I was wrongly believing that the LCReader keeps ownership of the lcio event.

@tmadlener
Copy link
Contributor Author

Seems I was wrongly believing that the LCReader keeps ownership of the lcio event.

I think that changed by going from the LCReader returned from the factory to the MTReader.

@andresailer andresailer merged commit 6f98cf9 into key4hep:master Nov 24, 2022
@tmadlener tmadlener deleted the fix-mem-leaks branch November 24, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @andresailer