Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use + std::to_string to convert integers before appending to a string #353

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jul 9, 2024

BEGINRELEASENOTES

ENDRELEASENOTES

See https://gcc.godbolt.org/z/qfojcnMK9 for an example. Should we worry that this has not been caught when testing? @mahmoudali2 @BrieucF

@jmcarcell jmcarcell changed the title Use + std::to_string to append to a string Use + std::to_string to convert integers before appending to a string Jul 9, 2024
@jmcarcell jmcarcell requested a review from mahmoudali2 July 31, 2024 07:44
@andresailer andresailer requested a review from BrieucF August 6, 2024 07:05
@BrieucF
Copy link
Contributor

BrieucF commented Aug 6, 2024

Thanks for spotting this Juan! I guess it would be difficult for the tests to see this, there is nothing wrong per-se and the names were still "unique" since the number of character being cut were different.

jmcarcell and others added 2 commits August 9, 2024 09:52
Co-authored-by: Brieuc Francois <brieuc.francois@cern.ch>
@jmcarcell
Copy link
Member Author

jmcarcell commented Aug 9, 2024

I'm merging this since it has been up for 1 month, feel free to edit in another PR

@jmcarcell jmcarcell merged commit a713f69 into main Aug 9, 2024
6 of 7 checks passed
@jmcarcell jmcarcell deleted the detelement branch August 9, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants