gpg: fixes for shell out during login #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxtaco
commented
Nov 25, 2015
maxtaco
commented
- Use --no-tty if we're forking from the service
- Say whether we're calling login from the CLI or the GUI, and use the reverse-sign technique if possible
- allow --emulate-gui flag in login in devel mode, so we can test the service forking GPG
- Ship fingerprints in binary over msgpack
- strip out dead code
- contextify GPG client
- Use --no-tty if we're forking from the service - Say whether we're calling login from the CLI or the GUI, and use the reverse-sign technique if possible - allow --emulate-gui flag in login in devel mode, so we can test the service forking GPG - Ship fingerprints in binary over msgpack - strip out dead code - contextify GPG client
|
R? @patrickxb when you get a chance? |
| } | ||
|
|
||
| // NewLogin creates a Login engine. username is optional. | ||
| // deviceType should be libkb.DeviceTypeDesktop or | ||
| // libkb.DeviceTypeMobile. | ||
| func NewLogin(g *libkb.GlobalContext, deviceType, username string) *Login { | ||
| func NewLogin(g *libkb.GlobalContext, deviceType string, username string, ct keybase1.ClientType) *Login { |
There was a problem hiding this comment.
The clientType needs to be plumbed through to the creation of the GpgKey
|
LGTM! |
maxtaco
added a commit
that referenced
this pull request
Nov 26, 2015
gpg: fixes for shell out during login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.