Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check eldest KID in ComputeKeyDiffs, fix ugly warning messages when eldest key not pgp key #1419

Merged
merged 6 commits into from
Nov 30, 2015
Merged

Check eldest KID in ComputeKeyDiffs, fix ugly warning messages when eldest key not pgp key #1419

merged 6 commits into from
Nov 30, 2015

Conversation

patrickxb
Copy link
Contributor

maxtaco
maxtaco reviewed Nov 30, 2015
View reviewed changes
go/libkb/identify_state.go
observedEldest := s.u.GetEldestKID()
if s.track != nil {
trackedEldest := s.track.GetEldestKID()
if observedEldest != trackedEldest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use KID.Eq?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@maxtaco
Copy link
Contributor

maxtaco commented Nov 30, 2015

I can't seem to repro the original issue right now. Does this patch fix the warning for you?

@patrickxb
Copy link
Contributor Author

To repro original warning, track a new user (with nacl eldest key) twice.

Yes, this fixes that.

@maxtaco
Copy link
Contributor

maxtaco commented Nov 30, 2015

Ok, great then!! 👍

@patrickxb patrickxb merged commit 8deb8ee into master Nov 30, 2015
@patrickxb patrickxb deleted the patrickxb/CORE-2112 branch November 30, 2015 16:30
@patrickxb patrickxb mentioned this pull request Nov 30, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickxb @maxtaco