libkb: optimization: only load necessary fields from user/lookup #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxtaco
commented
Dec 4, 2015
maxtaco
commented
- strip out some dead code too
- strip out some dead code too
|
PTAL @patrickxb ? |
|
It turns out there is also a security flaw here. The user shouldn't trust the server's output for sigs, which isn't trusted. This PR fixes that. |
| @@ -137,7 +137,15 @@ func (u *User) ToTrackingStatementBasics(errp *error) *jsonw.Wrapper { | |||
| } | |||
|
|
|||
| func (u *User) ToTrackingStatementSeqTail() *jsonw.Wrapper { | |||
| return u.sigs.AtKey("last") | |||
There was a problem hiding this comment.
this isn't a good idea, since this dictionary arrives from the server, untrusted.
|
LGTM |
maxtaco
added a commit
that referenced
this pull request
Dec 4, 2015
libkb: optimization: only load necessary fields from user/lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.