engine: bugfix for user switching #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL: @oconnor663 |
| @@ -44,6 +44,10 @@ func (e *LoginCurrentDevice) SubConsumers() []libkb.UIConsumer { | |||
|
|
|||
| // Run starts the engine. | |||
| func (e *LoginCurrentDevice) Run(ctx *Context) error { | |||
| e.G().Log.Debug("+- LoginCurrentDevice.Run") | |||
| defer func() { | |||
| e.G().Log.Debug("- LoginCurrentDevice.Run") | |||
There was a problem hiding this comment.
debugging, sweet sweet debugging!
maxtaco
force-pushed
the
maxtaco/fix-user-change-bug
branch
from
b8672a0 to
fbcf92e
Compare
| if err != nil { | ||
| e.G().Log.Debug("error loading user profile: %#v", err) | ||
| return err | ||
| } | ||
| if !me.HasDeviceInCurrentInstall() { | ||
| if !me.HasDeviceInCurrentInstall(did) { |
There was a problem hiding this comment.
can't pull the global device here, have to pull the one you want to talk about
|
Looks good! |
- intro'ed in bdfde6a - pass in the correct user to LoadUser - also pass in the right device ID
maxtaco
force-pushed
the
maxtaco/fix-user-change-bug
branch
from
ca1e665 to
d48345c
Compare
maxtaco
added a commit
that referenced
this pull request
Dec 4, 2015
engine: bugfix for user switching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intro'ed in bdfde6a