Use GetPassphrase everywhere (via delegate UI if available) #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, err | ||
| } | ||
| if version != libkb.PaperKeyVersion { | ||
| e.G().Log.Debug("paper version mismatch: generated paper key version = %d, libkb version = %d", version, libkb.PaperKeyVersion) |
|
Once remaining Q, otherwise 👍 |
patrickxb
force-pushed
the
patrickxb/CORE-2180
branch
from
dc23bbd to
630a328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all use of the SecretUI to use GetPassphrase instead of the four existing functions.
The result of this is that if desktop app is running, the desktop app pinentry will be used instead of gpg pinentry (or terminal).
Note that after this gets approved, I will submit another PR that cleans up the SecretUI protocol so it just has GetPassphrase() and cleans up all the related code. There is a lot of cruft now, but I wanted to get the version with no protocol changes in first.
r? @maxtaco
cc: @chrisnojima @cjb