Help detect typos in device add phrase #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -149,6 +154,9 @@ func (p *provisioner) runProtocolWithCancel() (err error) { | |||
| p.canceled = true | |||
| return ErrCanceled | |||
| case err = <-ch: | |||
| if _, ok := err.(rpc.CanceledError); ok && !p.helloReceived { | |||
| return ErrHelloTimeout | |||
There was a problem hiding this comment.
does this error export properly over RPC? We'll likely need it for the desktop client, I'm guessing.
There was a problem hiding this comment.
That's not the error that goes over RPC. The engine checks for it and returns its own error. But the engine error isn't exportable, so I'll fix that.
|
Looks great. 👍 My only reservation is, did we pick the right timeout? Though I see arguments for and against. |
|
Not sure. We had the one bug report where the user had a really slow connection to keybase.io...so maybe 15s isn't enough. |
Checks words entered are in list Checks number of words Short timeout on Hello, custom error message
patrickxb
force-pushed
the
patrickxb/CORE-2232
branch
from
7f8a314 to
ce8c507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks words entered are in list
Checks number of words
Short timeout on Hello, custom error message
Fixes CORE-2232
r? @maxtaco