Fix login cancel #1546
Closed
Fix login cancel #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,3 +115,23 @@ func (c *CmdLogin) GetUsage() libkb.Usage { | |||
| API: true, | |||
| } | |||
| } | |||
|
|
|||
| func (c *CmdLogin) Cancel() error { | |||
There was a problem hiding this comment.
where is this called from?
There was a problem hiding this comment.
|
This looks good, a few questions... |
Plumb a real context.Context through LoginProvision Fix kex2 pollLoop to stop when context canceled
patrickxb
force-pushed
the
patrickxb/CORE-2216
branch
from
16ec39e to
8318532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CORE-2216
Plumbed real context.Context through LoginProvision.
cmd_login Cancel() handler cancels via context cancel and waits for command to finish.
r? @maxtaco