-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve login error messages for no synced pgp key, bad passphrase #1652
Conversation
189e9ff
to
2135779
Compare
@@ -566,6 +566,10 @@ func (e *LoginProvision) syncedPGPKey(ctx *Context) (libkb.GenericKey, error) { | |||
return unlocked, nil | |||
} | |||
|
|||
func (e *LoginProvision) noSyncedKeyMsg() string { | |||
return fmt.Sprintf("ERROR!\n\nSorry, you have a PGP private key that Keybase doesn't have a copy of. You need to prove you're you. Any of these will unlock this computer:\n\n1. reset your account and start fresh: https://keybase.io/%s and click \"reset my keys\" in the gear\n2. install GPG and put your PGP private key on this machine and try again\n3. go back and provision with another device or paper key\n\n", e.user.GetName()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this output to client/
? I try to keep U/I-related stuff there as much as possible. We can import/export the error type and then switch on it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need a different error type then as libkb.NoKeyError is used for other missing keys as well and then the client output would be incorrect...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think that makes sense.
On Thursday, January 7, 2016, Patrick Crosby notifications@github.com
wrote:
In go/engine/login_provision.go
#1652 (comment):@@ -566,6 +566,10 @@ func (e *LoginProvision) syncedPGPKey(ctx *Context) (libkb.GenericKey, error) {
return unlocked, nil
}+func (e *LoginProvision) noSyncedKeyMsg() string {
- return fmt.Sprintf("ERROR!\n\nSorry, you have a PGP private key that Keybase doesn't have a copy of. You need to prove you're you. Any of these will unlock this computer:\n\n1. reset your account and start fresh: https://keybase.io/%s and click "reset my keys" in the gear\n2. install GPG and put your PGP private key on this machine and try again\n3. go back and provision with another device or paper key\n\n", e.user.GetName())
Will need a different error type then as libkb.NoKeyError is used for
other missing keys as well and then the client output would be incorrect...—
Reply to this email directly or view it on GitHub
https://github.com/keybase/client/pull/1652/files#r49116528.
PTAL |
312d37e
to
798a530
Compare
the wording looks good to me. no idea code-wise! |
Ok looks good thanks for fixing. Please also reserve this constant in keybase/keybase/lib/status_codes |
I did. |
r? @malgorithms