Fix Chat Input Crashes on Android #20058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input was crashing when you sent messages that had modified the native selection props. It crashed when you cleared the text because it would set the text to empty, and reused a cached selection that was out of bounds of an empty string. For example, say you type "hello @" and autocomplete to "hello @foo". We do some text selection magic to insert the @foo and put your cursor in the correct spot. The Selection start and end indicies are both 11. When you submit to message, we clear the text. When we clear the text, RN keeps reusing those selection indices (of 11) and Android complains the selection is outside of the bounds of the text ("" has a length of 0, but you want to move the cursor to position 11, outside the bounds of 0). The workaround here is to set the selection at the same time as the text. The RN Issue is: facebook/react-native#25265
chrisnojima
approved these changes
Oct 1, 2019
|
I tried it and it seems fine on iOS too. |
chrisnojima
approved these changes
Oct 2, 2019
| @@ -67,9 +67,13 @@ class PlainInput extends Component<InternalProps> { | |||
| } | |||
| const newTextInfo = fn(currentTextInfo) | |||
| checkTextInfo(newTextInfo) | |||
| this.setNativeProps({text: newTextInfo.text}) | |||
| // If we're android, let's workaround this Issue: https://github.com/imnapo/react-native-cn-richtext-editor/issues/81 | |||
buoyad
approved these changes
Oct 2, 2019
buoyad
reviewed
Oct 2, 2019
| this.setNativeProps({ | ||
| selection: this._sanityCheckSelection(newTextInfo.selection, newTextInfo.text), | ||
| text: newTextInfo.text, | ||
| }) | ||
| this._lastNativeText = newTextInfo.text |
There was a problem hiding this comment.
We should likely set this._lastNativeSelection here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input was crashing when you sent messages that had modified the
native selection props. It crashed when you cleared the text because it
would set the text to empty, and reused a cached selection that was out
of bounds of an empty string.
For example, say you type "hello @" and autocomplete to "hello @foo". We
do some text selection magic to insert the @foo and put your cursor in
the correct spot. The Selection start and end indicies are both 11. When
you submit to message, we clear the text. When we clear the text, RN
keeps reusing those selection indices (of 11) and Android complains the
selection is outside of the bounds of the text ("" has a length of 0,
but you want to move the cursor to position 11, outside the bounds of
0).
The workaround here is to set the selection at the same time as the
text.
The RN Issue is: facebook/react-native#25265
@buoyad since I think he has the most context here.
@keybase/react-hackers