Add --skipcache option to id command #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,15 +34,17 @@ func (v *CmdID) ParseArgv(ctx *cli.Context) error { | |||
| } | |||
| v.trackStatement = ctx.Bool("track-statement") | |||
| v.useDelegateUI = ctx.Bool("ui") | |||
| v.skipCache = ctx.Bool("skip-cache") | |||
There was a problem hiding this comment.
Could we rename this skip-proof-cache? There's another cache for the identify results and don't want callers to get confused about which cache they are skipping...
|
LGTM, just a rename request on the flag name. |
zanderz
force-pushed
the
zanderz/CORE-2416
branch
from
9d25fd9 to
7e38700
Compare
| cli.BoolFlag{ | ||
| Name: "s, skip-proof-cache", | ||
| Usage: "Skip cached proofs, force re-check", | ||
| HideUsage: !develUsage, |
There was a problem hiding this comment.
hey I just realized, I copied this from another command - is this supposed to be only for devel?
There was a problem hiding this comment.
I'm not sure. Let's start with devel only for now, as that sounds like what the ticket is for.
zanderz
pushed a commit
that referenced
this pull request
Mar 14, 2016
Add --skipcache option to id command
|
Made it user visible with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maxtaco @patrick