Desktop 1774 part 1 #4199
Merged
Desktop 1774 part 1 #4199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const fields = (error.fields || []).reduce((acc, f) => { | ||
| acc[f.key] = f.value | ||
| const fields = (Array.isArray(error.fields) ? error.fields : []).reduce((acc, f) => { | ||
| const k = f && typeof f.key === 'string' ? f.key : '' |
There was a problem hiding this comment.
🐑 This is a little wonky (falling back to the key of '') but probably not worth complicating it more. Flow isn't really helping here :/
There was a problem hiding this comment.
it was falling back to undefined before
|
👍 w/ |
|
why not use |
|
@chrisnojima Flow's new support for Exact types is different than our version of Exact types. It's lacking a couple things we use and our Exact types work for (facebook/flow#2405) So this change renamed our $Exact (which conflicts with Flow's new exact support) to just Besides that reason for using our exact, our eslint flow plugin does not like |
|
👍 |
|
@MarcoPolo wonder why this didn't merge in? |
chromakode
approved these changes
Sep 14, 2016
* Add type defs * Fix flow errors from adding typed connector * Attribution * Make loggerMiddleware type any
chromakode
approved these changes
Sep 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keybase/react-hackers
Upgrades us to flow v0.32! a precursor to a better typed connect