WIP: RN update to 0.46 #7679
Closed
WIP: RN update to 0.46 #7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have been running this branch, feels good to me. |
|
I think before this is merged we should run through the smoke test (and go
through all the dumb screens) and the same for desktop
…On Fri, Jul 7, 2017 at 8:41 PM Chris Ball ***@***.***> wrote:
Have been running this branch, feels good to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7679 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAfhU01oTWqNAZNideyKN2PGtd33y11tks5sLtBPgaJpZM4ORV9b>
.
|
…e need it to actually turn off the statusbar
|
A lot of our layout was using flexGrow incorrectly which lead to content being rendered below the fold. At a top level I'm forcing the nav children to take up the full non-tabbar space |
…ut invalid props. in icon don't mutate style if we don't need to w/ omit
|
replaced by this cleanup pr: #7759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our RN to 0.46. This also means our react dependency got updated to 16 alpha which affects desktop also.
Additionally the update to 0.46 updates some tooling which allows us to see the dimensions of views in the react devtools which led me to discover some high level layout problems. This PR also addresses this. Before we had flex:1 screens which (depending on the contents) push the screens below the fold. This lead to bugs about things being cut off.
TODO:
Known issues:
notes:
Plan for Addons in React 16 facebook/react#9207
No react-perf on desktop :(
This changes enough things that we should defer until after searchv3