This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
More GNU S2K dummy: don't bother to read the hash #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oconnor663 can you take a look? |
|
This looks fine to me, but I don't understand this code very well. Was trying to compute the hash giving an error that we had to work around? |
|
Yes, I can't repro the issue, but others have (see keybase/keybase-issues#1885). Some GPGs output value |
maxtaco
added a commit
that referenced
this pull request
Feb 7, 2016
More GNU S2K dummy: don't bother to read the hash
maxtaco
added a commit
to keybase/client
that referenced
this pull request
Feb 7, 2016
maxtaco
added a commit
to keybase/client
that referenced
this pull request
Feb 7, 2016
maxtaco
added a commit
to keybase/client
that referenced
this pull request
Feb 8, 2016
maxtaco
added a commit
to keybase/client
that referenced
this pull request
Feb 8, 2016
- vendor in keybase/go-crypto#8 and keybase/go-crypto#10 - vendor in new RSA library (with big E)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bother the read the hash, which is sometimes set to
0in GNU S2K dummy configuration.