This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
openpgp: ignore unsupported critical packets on cross-signed WoT sigs #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oconnor663 |
| @@ -393,7 +393,20 @@ EachPacket: | |||
| current.UserId = pkt | |||
| case *packet.Signature: | |||
|
|
|||
| // First handle the case of a self-signature. According to RFC8440, | |||
| // These are signatures but other people on this key. Let's just ignore them | |||
|
lgtm |
maxtaco
added a commit
that referenced
this pull request
Feb 29, 2016
openpgp: ignore unsupported critical packets on cross-signed WoT sigs
This was referenced Feb 29, 2016
|
Has it been submitted upstream? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
keybase id sneak