preliminary ECDH support #37
Conversation
maxtaco
commented
Oct 3, 2016
maxtaco
commented
- make sure that we can import ECDH private keys
- make some test cases
- write out some test data
- start on actual ECDH decryption, but the crux is unimplemented
- make sure that we can import ECDH private keys - make some test cases - write out some test data - start on actual ECDH decryption, but the crux is unimplemented
|
@oconnor663 can you take a look? This allows us to import and pass through ECDH keys, but I didn't implement decryption with ECDH keys. |
|
With this fix, we're now able to run |
| @@ -366,6 +374,24 @@ func (pk *PrivateKey) parseElGamalPrivateKey(data []byte) (err error) { | |||
| return nil | |||
| } | |||
|
|
|||
| func (pk *PrivateKey) parseECDHPrivateKey(data []byte) (err error) { | |||
There was a problem hiding this comment.
This function looks like it's a duplicate of the ones around it. It looks like the only difference between them is the types they cast into? Is that a "don't fix what ain't broke" thing?
There was a problem hiding this comment.
Yeah, it at least will allow reading of the key without crashing (what we used to do with an actual panic). I ought to go ahead and implement ECDH but it's tricky and takes a lot of tinkering, so I think it's worth it to put off for now, and at least get import/export of these keys working.
|
Looks fine to me, with the one question above. |
