Remove TrustedApplications (deprecated in Catalina) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, this passes for me locally. |
gabriel
reviewed
Dec 20, 2019
| @@ -124,6 +85,8 @@ func DeleteItemRef(ref C.CFTypeRef) error { | |||
| var ( | |||
| // KeychainKey is key for kSecUseKeychain | |||
| KeychainKey = attrKey(C.CFTypeRef(C.kSecUseKeychain)) | |||
| // KeychainDataProtectionKey is key for kSecUseDataProtectionKeychain | |||
| KeychainDataProtectionKey = attrKey(C.CFTypeRef(C.kSecUseDataProtectionKeychain)) | |||
There was a problem hiding this comment.
kSecUseDataProtectionKeychain is only available in macOS 10.15, causing compilation error on CI. It might be worth adding that in a seperate PR?
|
Closed via #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trusted application stuff appears to have been deprecated in Catalina.
https://forums.developer.apple.com/thread/118479
I don't see any use of it outside of macos_test.go.