change check_url route to use query param instead of path #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the username in check_url (the one keybase calls to see that a proof is being hosted by the remote domain) from being a url path param to a query string param.
this is better if the username happens to have characters in it that need to be url-encoded (e.g. a period).
this is a breaking change for any existing implementations, so it probably requires bumping the version to
0.2.0. anyone upgrading to this code would not need to change anything on their side (unless they have their own integration tests), but they would need to tell keybase to point at the slightly different url. this is an easy change on the keybase side. we just need to know to do it for you.