Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine how ConfigSource names are being used #24192

Closed
shawkins opened this issue Oct 20, 2023 · 0 comments · Fixed by #28411
Closed

Refine how ConfigSource names are being used #24192

shawkins opened this issue Oct 20, 2023 · 0 comments · Fixed by #28411
Assignees
@shawkins
Labels
area/dist/quarkus kind/enhancement Categorizes a PR related to an enhancement release/25.0.0 team/cloud-native

Comments

@shawkins
Copy link
Contributor

Description

With #13608 it was noted that the direct exposure of ConfigSource names in show-config and now the additional property validation that is being done is not a good user experience. At this level users should probably see something simple like - cli, env, just the properties file name (conf/keycloak.conf)
@ghost ghost added the team/cloud-native label Oct 23, 2023
@vmuzikar vmuzikar added kind/enhancement Categorizes a PR related to an enhancement and removed kind/task labels Oct 23, 2023
@shawkins shawkins self-assigned this Apr 3, 2024
@shawkins shawkins mentioned this issue Apr 3, 2024
Merged
shawkins added a commit to shawkins/keycloak that referenced this issue Apr 9, 2024
@shawkins
task: use simple display names for config sources
40a8418 
closes: keycloak#24192

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
vmuzikar pushed a commit that referenced this issue Apr 9, 2024
@shawkins
task: use simple display names for config sources (#28411)
9774ded 
closes: #24192

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
area/dist/quarkus kind/enhancement Categorizes a PR related to an enhancement release/25.0.0 team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

task: use simple display names for config sources shawkins/keycloak
2 participants
@shawkins @vmuzikar