Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 11.0.0 and drop support for 8.0.0 #357

Closed
wants to merge 3 commits into from
Closed

Add support for 11.0.0 and drop support for 8.0.0 #357

wants to merge 3 commits into from

Conversation

klausenbusk
Copy link
Contributor

#356 is currently blocked on this PR.

@klausenbusk klausenbusk mentioned this pull request Aug 3, 2020
Merged
@klausenbusk
Copy link
Contributor Author

I assume the error is caused by this change: keycloak/keycloak@6005503

Error: error sending POST request to /auth/admin/realms/terraform-tduhynsuat/components: 400 Bad Request. Response body: {"errorMessage":"Missing configuration for Groups Path"}

@klausenbusk
Copy link
Contributor Author

klausenbusk commented Aug 4, 2020 •
edited
Loading

... and now I broke all <11.0.0.. How can we support 11.0.0 without breaking < 11.0.0? Edit: keycloakVersionIsGreaterThanOrEqualTo. It need to be moved through and upper-cased (Keycloak...)

@mrparkers
Copy link
Contributor

Yeah... I was afraid that something like this might happen due to a major release introducing breaking API changes.

I haven't dug too deep in this yet, but it looks like Keycloak 11 is expecting groups.path for the LDAP group mapper to always be provided, and all previous versions are failing when that is provided.

If this is the case, then we'll have to start doing version checking at runtime instead of just doing it during tests. I can dig into this more when I have some free time.

@klausenbusk

This comment has been minimized.

Sign in to view
@klausenbusk

This comment has been minimized.

Sign in to view
@klausenbusk
Copy link
Contributor Author

Hmm... Now 11.0.0 is broke..

Now all the CI is green. Could you take a look at the last commit?

@klausenbusk
Send only ldap groups path if version >= 11.0.0
3a93030 
Groups path was added in 11.0.0[1], and using it with older
versions doesn't work.

[1] keycloak/keycloak@6005503
klausenbusk
klausenbusk commented Aug 6, 2020
View reviewed changes
keycloak/ldap_group_mapper.go
},
}

if KeycloakVersionIsGreaterThanOrEqualTo(keycloakClient, "11.0.0") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this, but maybe it worth it anyway as it is more explicit.

@svenstaro
Copy link

@klausenbusk This needs a rebase.

@klausenbusk
Copy link
Contributor Author

klausenbusk commented Sep 7, 2020 •
edited
Loading

I think this was <somehow> fixed as part of: #369

@klausenbusk klausenbusk closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klausenbusk @mrparkers @svenstaro