Add Sparkle distribution engine #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about deltas? Could eventually define a <item>
<title>Version 2.0 </title>
<link>https://myproductwebsite.com</link>
<sparkle:version>2.0</sparkle:version>
<description>foo bar baz</description>
<pubDate>Wed, 09 Jan 2006 19:20:11 +0000</pubDate>
<enclosure url="http://you.com/2.0_full.zip"
length="123"
type="application/octet-stream"
sparkle:edSignature="..." />
<sparkle:deltas>
<enclosure url="http://you.com/1.5-2.0.delta"
sparkle:deltaFrom="1.5"
length="1485"
type="application/octet-stream"
sparkle:edSignature="..." />
<enclosure url="http://you.com/1.6-2.0.delta"
sparkle:deltaFrom="1.6"
length="1428"
type="application/octet-stream"
sparkle:edSignature="..." />
</sparkle:deltas>
</item> |
|
I'm not sure if Sparkle will work with relative |
ezekg
force-pushed
the
feature/sparkle-electron-engines
branch
from
df5bfbe to
d487163
Compare
ezekg
commented
Oct 26, 2021
|
|
||
| include Rails.application.routes.url_helpers | ||
|
|
||
| def initialize(account:, product:, releases:) | ||
| def initialize(account:, product:, releases:, host: 'api.keygen.sh') |
There was a problem hiding this comment.
Maybe we can eventually use Current.host here, if we get traction with custom domains.
ezekg
commented
Oct 26, 2021
| @@ -4,19 +4,21 @@ | |||
|
|
|||
| class GenerateAppcastService < BaseService | |||
| SUPPORTED_FILETYPES = %i[zip dmg pkg mpkg tar.gz tar.bz2].freeze | |||
| SUPPORTED_PLATFORMS = %i[macos windows].freeze | |||
| SUPPORTED_PLATFORMS = %i[macos windows windows-x86 windows-x64].freeze | |||
There was a problem hiding this comment.
What if we just removed filtering platforms and filetypes? Unsupported items would simply be ignored, and it’d be more forward compatible.
ezekg
force-pushed
the
feature/sparkle-electron-engines
branch
2 times, most recently
from
d4f2e94 to
d146389
Compare
ezekg
changed the title
|
Add caching. |
ezekg
force-pushed
the
master
branch
7 times, most recently
from
ad595e0 to
a5b0dc0
Compare
ezekg
force-pushed
the
master
branch
2 times, most recently
from
3fc8952 to
d515cb6
Compare
ezekg
force-pushed
the
master
branch
2 times, most recently
from
a78fcc6 to
1462020
Compare
ezekg
force-pushed
the
master
branch
4 times, most recently
from
b18f142 to
ac4cdaf
Compare
ezekg
force-pushed
the
master
branch
6 times, most recently
from
cab84a1 to
a390331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #478. Requires #470 to be able to read a product.