support for user mode in run-test.sh #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/run_tests.sh
Outdated
| @@ -80,7 +80,6 @@ esac | |||
| # Permissions-related sanity checking | |||
| if [[ "$USER_MODE" -eq "0" && $EUID -ne 0 ]]; then | |||
| echo "This script must be run as root in order to install dependencies. Use -u for user mode." 1>&2 | |||
| exit 1 | |||
There was a problem hiding this comment.
Why not exit after this error message? Same comment below.
There was a problem hiding this comment.
Oh, right, this one was too much. Fixed. The other one is needed, otherwise the script is never accepting -u.
Signed-off-by: Karsten Ohme <karsten.ohme@ohmesoftware.de>
koh-osug
force-pushed
the
run-test-fix
branch
from
1f0e9d4 to
0881bb5
Compare
24 tasks
maugustosilva
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test script supports a user mode, but fails when it is used.