Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Handlers out of Main #125

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Refactor Handlers out of Main #125

merged 1 commit into from
Oct 12, 2020

Conversation

lukehinds
Copy link
Member

Main is way to heavy and crowded. Let's start to move some of the
code over into their own mods.

This change moves out the handlers. It also removes a lot of unused imports.

I also removed the sea of commented code out, if we need it, its
in gits history to grab at a later juncture.

Main is way to heavy and crowded. Let's start to move some of the
code over into their own mods.

This change moves out the handlers.

I also removed the sea of commmented code out, if we need it, its
in gits history to grab at a later juncture.
@lukehinds
Copy link
Member Author

lukehinds commented Oct 12, 2020

Error writing files: failed to resolve mod "handlers": cannot parse /home/runner/work/rust-keylime/rust-keylime/src/handlers.rs

Anyone know what cargo fmt is rambling about?

@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2020

👍 to the idea and work. CI is failing with:

Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `comment_width = 78`, unstable features are only available in nightly channel.
Warning: can't set `normalize_comments = false`, unstable features are only available in nightly channel.
Error writing files: failed to resolve mod `handlers`: cannot parse /home/runner/work/rust-keylime/rust-keylime/src/handlers.rs

@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2020

@lukehinds
Copy link
Member Author

Anyone know what cargo fmt is rambling about?

These come up:

* [rust-lang/rustfmt#4431](https://github.com/rust-lang/rustfmt/issues/4431)

* [rust-lang/rustfmt#3901](https://github.com/rust-lang/rustfmt/issues/3901)

I found the same when I googled around, I am still unsure. It builds fine and if I add a whitespace somewhere fmt tells me what to fix. After fixing all the fmt recommendations it comes up with the statement about not being able to parse.

@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2020

From what I gather it's a rustfmt bug.

@lukehinds lukehinds merged commit 107568c into keylime:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants