docs: Add remaining Keyman Engine for Android API's for KMManager #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
requested changes
Jun 18, 2024
developer/engine/android/18.0/KMManager/executeHardwareKeystroke.md
Outdated
Show resolved
Hide resolved
developer/engine/android/18.0/KMManager/executeHardwareKeystroke.md
Outdated
Show resolved
Hide resolved
developer/engine/android/18.0/KMManager/executeHardwareKeystroke.md
Outdated
Show resolved
Hide resolved
| Returns the KMKeyboard object. | ||
|
|
||
| ## Description | ||
| The `getKMKeyboard()` method returns the KMKeyboard for the specified keyboard type. |
There was a problem hiding this comment.
KMKeyboard should link to the type
There was a problem hiding this comment.
Added KMKeyboard page and link in 7f99859
| : Non-negative position of the installed lexical model | ||
|
|
||
| ### Returns | ||
| Returns a dictionary containing information on the specified lexical model. |
There was a problem hiding this comment.
The dictionary should be documented here (and the type Hashmap<String, String>
developer/engine/android/18.0/KMManager/setCanRemoveKeyboard.md
Outdated
Show resolved
Hide resolved
developer/engine/android/18.0/KMManager/setCanRemoveKeyboard.md
Outdated
Show resolved
Hide resolved
developer/engine/android/18.0/KMManager/setCanRemoveKeyboard.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Durdin <marc@durdin.net>
|
I think I've addressed all the comments so far. Ready to re-review |
mcdurdin
approved these changes
Jul 2, 2024
|
|
||
| The KMKeyboard is the core class which provides most of the methods you will need to develop an in-app or system keyboard with Keyman Engine | ||
|
|
||
| <!-- Fill in examples of how to use, etc. --> |
Comment on lines
+59
to
+62
| ```java | ||
| // Send keystroke to KeymanWeb for processing: will return true to swallow the keystroke | ||
| return KMManager.executeHardwareKeystroke(code, keymanModifiers, keyboardType, Lstates, androidModifiers); | ||
| ``` |
There was a problem hiding this comment.
Hmm, should this be a TODO for future improvement then?
| : `KeyboardType.KEYBOARD_TYPE_INAPP` or `KeyboardType.KEYBOARD_TYPE_SYSTEM` | ||
|
|
||
| ### Returns | ||
| Returns the KMKeyboard object. |
| Returns a list of all the installed lexical models. | ||
|
|
||
| ## Description | ||
| Use this method to get details of all the installed lexical models. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds remaining API pages to KMManager pointed out in an earlier review comment
help.keyman.com/developer/engine/android/18.0/KMManager/index.md
Lines 179 to 180 in 73c9bc1
Originally posted by @mcdurdin in #1268 (comment)