Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[galaxie_mnemonic] Remove kvks as keyboards are mnemonic #3110

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

LornaSIL
Copy link
Contributor

Relates to #2793

This was definitely complicated. If you look at the history the targets have changed multiple times. I hope I got it right.

@mcdurdin
Copy link
Member

I'm just wondering if it makes sense to remove the .kvks entirely, beacuse it is still useful for US English base keyboard and largely for UK English, even if it gets increasingly unhelpful for other base keyboards (this is also something in the back of my mind that we want to support in the future -- translating the .kvk alongside the .kmx)

DavidLRowe
DavidLRowe previously approved these changes Sep 19, 2024
@LornaSIL
Copy link
Contributor Author

@mcdurdin I can revisit it if you wish, but what's there was so inconsistent I just finally had to decide something. Currently, it's not available to use online: https://keyman.com/keyboards/galaxie_greek_mnemonic

but the .kvk was in the keyboard .kmp
I've redone the 2 keyboards and 1 package 3 times on my computer as I've tried to figure out what to do.

@LornaSIL LornaSIL merged commit f927c0d into keymanapp:master Sep 19, 2024
2 checks passed
@LornaSIL LornaSIL deleted the galaxie_mnemonic branch September 19, 2024 21:10
@mcdurdin
Copy link
Member

OK, let's leave it for now. Mnemonic keyboard support should improve in upcoming releases -- cross-platform support and also hopefully we can address kvk at the same time, and get it working better without lots of engineering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants