Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[greek_tonizo] Initial submission of greek_tonizo #3316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tonizo2025
Copy link

greek_tonizo is a polytonic greek keyboard for mobile devices

greek_tonizo is a polytonic greek keyboard for mobile devices
@tonizo2025 tonizo2025 closed this Feb 4, 2025
@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@tonizo2025
Copy link
Author

Ready for review

@DavidLRowe
Copy link
Contributor

I think you must have inadvertently closed this pull request.

@DavidLRowe DavidLRowe reopened this Feb 5, 2025
@tonizo2025
Copy link
Author

tonizo2025 commented Feb 5, 2025 via email

@LornaSIL
Copy link
Contributor

LornaSIL commented Feb 6, 2025

Is there any reason this keyboard won't work on desktop? It looks to me like it's working, but I haven't tested it thoroughly. We generally prefer keyboards to also include desktop if possible. However, if it can't easily be changed to support desktop we can accept mobile-only.

In addition to that, here are some things it would be good to fix:

  • In LICENSE.md please make the copyright extend to 2025. So, it would be Copyright © 2024-2025 Amaryllis Deliyanni
  • In the HISTORY.md file I see you bumped the version to v2.0. Since we never release keymangreek you don't need to bump the version UNLESS you released it under v1.0 somewhere else. If that's the case, it's appropriate to bump.
    • The .kmn file still says v1.0. So, whichever version you decide on, the two files need reconciling.
  • If you don't plan to support desktop then there is no reason to include the .kvks file (On-screen keyboard). If you decide the keyboard does support desktop then you can change store(&TARGETS) to store(&TARGETS) 'any' and there is no need to list every target
  • If you decide to support desktop then add the .kmx to the list of files in the .kps.
  • If you decide not to support desktop (and thus web), then remove the .kvk file from the list of files in .kps
  • Add LICENSE.md to the list of files in the .kps
  • Then, in the .kps go to the Details tab and add welcome.htm, readme.htm and LICENSE.md here:
    image
  • In the welcome.htm file you are still referencing keymangreek. You might want to change that.
  • We require all keyboards in the release folder to include online help files. You can:
    • Create a help folder in source
    • Copy welcome.htm and all the graphics it uses to the help folder.
    • Rename welcome.htm to greek_tonizo.php
    • Open greek_tonizo.php in a text editor.
    • Delete lines 1-15 all the way through the <h1>
    • Delete the last two lines (body and html tags)
    • Go back to the top and paste the following php header in there and save:
<?php 
  $pagename = 'greek_tonizo Keyboard Help';
  $pagetitle = $pagename;
  require_once('header.php');
?>

Otherwise, it looks good!

@tonizo2025
Copy link
Author

tonizo2025 commented Feb 6, 2025 via email

@LornaSIL
Copy link
Contributor

LornaSIL commented Feb 7, 2025

Ok, I can live with that. That means these things still need doing:

  • In LICENSE.md please make the copyright extend to 2025. So, it would be Copyright © 2024-2025 Amaryllis Deliyanni
  • Just select "mobile" as the target and don't list every single target.
  • Comment out the .kvks file for this release. Feel free to leave the file in the Pull Request for future reference.
  • Remove the .kvk file from the list of files in .kps
  • Add LICENSE.md to the list of files in the .kps
  • Then, in the .kps go to the Details tab and add welcome.htm, readme.htm and LICENSE.md here:
    image
  • We require all keyboards in the release folder to include online help files. You can:
    • Create a help folder in source
    • Copy welcome.htm and all the graphics it uses to the help folder.
    • Rename welcome.htm to greek_tonizo.php
    • Open greek_tonizo.php in a text editor.
    • Delete lines 1-15 all the way through the <h1>
    • Delete the last two lines (body and html tags)
    • Go back to the top and paste the following php header in there and save:
<?php 
  $pagename = 'greek_tonizo Keyboard Help';
  $pagetitle = $pagename;
  require_once('header.php');
?>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants