-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[greek_tonizo] Initial submission of greek_tonizo #3316
base: master
Are you sure you want to change the base?
Conversation
greek_tonizo is a polytonic greek keyboard for mobile devices
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
Ready for review |
I think you must have inadvertently closed this pull request. |
Yes, I have!
But I did not know how to open it again.
What do i need to do to reopen it?
Yahoo Mail – Email Simplified
On Wed, 5 Feb 2025 at 2:07, ***@***.***> wrote:
Reopened #3316.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Hi Lorna,
Thanks for your detailed notes on greek_tonizo. I am going to implement them asap.
keymangreek is our polytonic keyboard for Windows (I think it works on Linux and Mac although I have not tested it personally). It was designed and implemented many years ago on Tavultesoft Keyman Developer, which allowed for the creation of a *.msi distribution file. The keymangreek.msi can be downloaded and installed for free to this day from the http://www.keymangreek.gr site.
The name "keymangreek" was suggested by Marc at the time and is now well established among local users, that is why I hesitate to replace it.
At some stage we also created a "keymangreek"-like keyboard for the iPhone/iPad. We called it iPolytonic and it is still offered for free from the Apple store.
Since our products are mainly addressed to native greek speakers and since the "tonizo" brand seems to work much better for them than "keymangreek", it is probably better to follow your advice and gradually migrate both "keymangreek" and "iPolytonic" to "greek_tonizo". However, until I thoroughly test greek_tonizo in Windows, I would like to start with greek_tonizo for mobile devices, which is more urgent especially for Android users.
How does this sound with you?
Amaryllis
On Thursday, 6 February 2025 at 19:00:00 EET, Lorna Evans ***@***.***> wrote:
Is there any reason this keyboard won't work on desktop? It looks to me like it's working, but I haven't tested it thoroughly. We generally prefer keyboards to also include desktop if possible. However, if it can't easily be changed to support desktop we can accept mobile-only.
In addition to that, here are some things it would be good to fix:
- In LICENSE.md please make the copyright extend to 2025. So, it would be Copyright © 2024-2025 Amaryllis Deliyanni
- In the HISTORY.md file I see you bumped the version to v2.0. Since we never release keymangreek you don't need to bump the version UNLESS you released it under v1.0 somewhere else. If that's the case, it's appropriate to bump.
- The .kmn file still says v1.0. So, whichever version you decide on, the two files need reconciling.
- If you don't plan to support desktop then there is no reason to include the .kvks file (On-screen keyboard). If you decide the keyboard does support desktop then you can change store(&TARGETS) to store(&TARGETS) 'any' and there is no need to list every target
- If you decide to support desktop then add the .kmx to the list of files in the .kps.
- If you decide not to support desktop (and thus web), then remove the .kvk file from the list of files in .kps
- Add LICENSE.md to the list of files in the .kps
- Then, in the .kps go to the Details tab and add welcome.htm, readme.htm and LICENSE.md here:
image.png (view on web)
- In the welcome.htm file you are still referencing keymangreek. You might want to change that.
- We require all keyboards in the release folder to include online help files. You can:
- Create a help folder in source
- Copy welcome.htm and all the graphics it uses to the help folder.
- Rename welcome.htm to greek_tonizo.php
- Open greek_tonizo.php in a text editor.
- Delete lines 1-15 all the way through the <h1>
- Delete the last two lines (body and html tags)
- Go back to the top and paste the following php header in there and save:
<?php
$pagename = 'greek_tonizo Keyboard Help';
$pagetitle = $pagename;
require_once('header.php');
?>
Otherwise, it looks good!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
greek_tonizo is a polytonic greek keyboard for mobile devices