Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): unit test to verify cross-project Unicode versions 🙀 #10183

Closed
srl295 opened this issue Dec 7, 2023 · 0 comments · Fixed by #11418
Closed

feat(core): unit test to verify cross-project Unicode versions 🙀 #10183

srl295 opened this issue Dec 7, 2023 · 0 comments · Fixed by #11418
Assignees
@srl295
Labels
core/ Keyman Core epic-ldml feat m:normalization
Milestone
A18S3

Comments

@srl295
Copy link
Member

srl295 commented Dec 7, 2023

  • unit test in core to compare icu Unicode version to Blocks.txt version (and report on Node.js version too)

Related to #9464 and somewhat related to #9466
@srl295 srl295 added this to the A17S28 milestone Dec 7, 2023
@srl295 srl295 self-assigned this Dec 7, 2023
@keymanapp-test-bot keymanapp-test-bot bot added core/ Keyman Core feat labels Dec 7, 2023
@srl295 srl295 modified the milestones: A17S28, A17S29, A17S30 Dec 11, 2023
@srl295 srl295 mentioned this issue Jan 4, 2024
Closed
2 tasks
@mcdurdin mcdurdin modified the milestones: A17S30, 18.0 Jan 12, 2024
@srl295 srl295 mentioned this issue Jan 20, 2024
Merged
@srl295 srl295 mentioned this issue Mar 8, 2024
Closed
@mcdurdin mcdurdin modified the milestones: 18.0, A18S1 Apr 19, 2024
srl295 added a commit that referenced this issue May 3, 2024
@srl295
chore(core): add a test to print out ICU and Unicode version
38681f0 
#10183
srl295 added a commit that referenced this issue May 9, 2024
@srl295
chore(core): load version data from node.js
5103a48 
Fixes: #10183
srl295 added a commit that referenced this issue May 11, 2024
@srl295
chore(core): Unicode version test
c7b51ba 
- load versions from node and ICU4C++ and Blocks.txt

Fixes: #10183
@srl295 srl295 mentioned this issue May 11, 2024
Merged
@darcywong00 darcywong00 modified the milestones: A18S1, A18S2 May 11, 2024
srl295 added a commit that referenced this issue May 13, 2024
@srl295
chore(core): add a test to print out ICU and Unicode version
337dd45 
#10183
srl295 added a commit that referenced this issue May 13, 2024
@srl295
chore(core): load version data from node.js
6a47ab7 
Fixes: #10183
srl295 added a commit that referenced this issue May 13, 2024
@srl295
chore(core): Unicode version test
d3f8e07 
- load versions from node and ICU4C++ and Blocks.txt

Fixes: #10183
srl295 added a commit that referenced this issue May 13, 2024
@srl295
chore(core): Unicode version test
b1d95ff 
- rename fallback to KMN_FALLBACK to not conflict with hedley
- comment out the cxx_icu test
- attempt to get wasm working

Fixes: #10183
srl295 added a commit that referenced this issue May 14, 2024
@srl295
chore(core): Unicode version test
9199c71 
- fix ambiguous path type

Fixes: #10183
srl295 added a commit that referenced this issue May 14, 2024
@srl295
chore(core): Unicode version test
1023ef2 
- refactor and support >= node version

Fixes: #10183
srl295 added a commit that referenced this issue May 16, 2024
@srl295
chore(core): Unicode version test
4fc2e39 
- support wasm: copy package.json, nodeversions.json and Blocks.txt into the keyboard area so that they can be mounted under wasm
- path changes to make the non-wasm part work as well

Fixes: #10183
srl295 added a commit that referenced this issue May 23, 2024
@srl295
fix(core): add a test to verify ICU and Unicode version
e5ee26a 
- load version data from node.js, Blocks.txt, and ICU4C
- support wasm: copy package.json, nodeversions.json and Blocks.txt into the keyboard area so that they can be mounted under wasm

also:
- rename 'fallback' macro to KMN_FALLBACK to not conflict with hedley in utfcodec.hpp
- fix ambiguous path type in tests

Fixes: #10183
srl295 added a commit that referenced this issue May 23, 2024
@srl295
test(core): build fix for test_unicode
f3a80f5 
- incorporate change from #11483

Fixes: #10183
srl295 added a commit that referenced this issue May 24, 2024
@srl295 @mcdurdin
test(core): update per review comments
e48f6c3 
Fixes: #10183

Co-authored-by: Marc Durdin <marc@durdin.net>
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3 May 24, 2024
srl295 added a commit that referenced this issue May 27, 2024
@srl295
test(core): clarify output of test_unicode
403d342 
- group output by functional area

#10183
@srl295 srl295 mentioned this issue May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
core/ Keyman Core epic-ldml feat m:normalization
Projects
None yet
Milestone
A18S3
Development

Successfully merging a pull request may close this issue.

test(core): verify Unicode and ICU versions cross-platform 🙀 keymanapp/keyman
3 participants
@srl295 @mcdurdin @darcywong00