Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(common): beta build trigger fails with inability to determine difference between earliest release 17 versions #10721

Closed
mcdurdin opened this issue Feb 15, 2024 · 2 comments
Closed

bug(common): beta build trigger fails with inability to determine difference between earliest release 17 versions #10721

mcdurdin opened this issue Feb 15, 2024 · 2 comments
Assignees
@mcdurdin
Labels
bug common/
Milestone
B17S1

Comments

@mcdurdin
Copy link
Member 

::warning::Error: subprocess error exit 128, fatal: ambiguous argument 'release-17.0.30-alpha%0Arelease@17.0.30-alpha': unknown revision or path not in the working tree.%0AUse '--' to separate paths from revisions, like this:%0A'git <command> [<revision>...] -- [<file>...]'%0A

https://build.palaso.org/buildConfiguration/Keyman_TriggerReleaseBuildsBeta/443151?buildTab=log&focusLine=1266&logView=flowAware&linesState=103
@mcdurdin
Copy link
Member Author

This happens because findLastHistoryPR is looking for the last PR on GitHub that affected the version history on the beta branch. That happens to be 16.0 beta commit 415c6c7.

We need to skip this when triggering the first beta build.

@mcdurdin mcdurdin added this to the B17S1 milestone Feb 15, 2024
@mcdurdin mcdurdin self-assigned this Feb 15, 2024
mcdurdin added a commit that referenced this issue Feb 15, 2024
@mcdurdin
chore: workaround release inc build block
fdc2cd4 
Fixes #10721.

This arose partly because of the change from release- to release@ in at
17.0.30-alpha (triggered by sentry req). Will require a corresponding
patch to CI script to pass the --from and --to parameters.
@mcdurdin mcdurdin mentioned this issue Feb 15, 2024
Merged
@mcdurdin
Copy link
Member Author

The fix isn't ideal because we have to pass --from and --to parameters in order for this to work. And that is buried inside increment-version.sh, so more patchwork required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug common/
Projects
None yet
Milestone
B17S1
Development

No branches or pull requests
1 participant
@mcdurdin