Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): visual-keyboard-compiler throwing instead of callbacks 🙀 #9438

Closed
srl295 opened this issue Aug 8, 2023 · 1 comment · Fixed by #9979
Closed

bug(developer): visual-keyboard-compiler throwing instead of callbacks 🙀 #9438

srl295 opened this issue Aug 8, 2023 · 1 comment · Fixed by #9979
Assignees
@srl295
Labels
bug developer/compilers/ developer/ epic-ldml
Milestone
A17S26

Comments

@srl295
Copy link
Member

srl295 commented Aug 8, 2023 

fr-t-k0-azerty.xml - info KM05002: Building keyboards/3.0/fr-t-k0-azerty.xml
fr-t-k0-azerty.xml - hint KM00009: Virtual key 'BKQUOTE' is not found in the CLDR VKey Enum table.
fr-t-k0-azerty.xml - hint KM00009: Virtual key 'MINUS' is not found in the CLDR VKey Enum table.
fr-t-k0-azerty.xml - hint KM00009: Virtual key 'LBRKT' is not found in the CLDR VKey Enum table.
fr-t-k0-azerty.xml - hint KM00009: Virtual key 'COLON' is not found in the CLDR VKey Enum table.
fr-t-k0-azerty.xml - hint KM00009: Virtual key 'BKQUOTE' is not found in the CLDR VKey Enum table.
fr-t-k0-azerty.xml - hint KM00009: Virtual key 'EXCLAMATION' is not found in the CLDR VKey Enum table.
fr-t-k0-azerty.xml - fatal KM05001: Unexpected exception: Error: Internal Error: could not find key id="extra" in layer "base", row "3"

Call stack:
Error: Internal Error: could not find key id="extra" in layer "base", row "3"
    at LdmlKeyboardVisualKeyboardCompiler.compileHardwareLayer (file:///usr/local/lib/node_modules/@keymanapp/kmc/node_modules/@keymanapp/kmc-ldml/build/src/compiler/visual-keyboard-compiler.js:32:27)
    at LdmlKeyboardVisualKeyboardCompiler.compile (file:///usr/local/lib/node_modules/@keymanapp/kmc/node_modules/@keymanapp/kmc-ldml/build/src/compiler/visual-keyboard-compiler.js:15:22)
    at buildLdmlKeyboardToMemory (file:///usr/local/lib/node_modules/@keymanapp/kmc/build/src/commands/buildClasses/BuildLdmlKeyboard.js:65:27)
    at async BuildLdmlKeyboard.build (file:///usr/local/lib/node_modules/@keymanapp/kmc/build/src/commands/buildClasses/BuildLdmlKeyboard.js:16:31)
    at async build (file:///usr/local/lib/node_modules/@keymanapp/kmc/build/src/commands/build.js:106:22)
    at async Command.<anonymous> (file:///usr/local/lib/node_modules/@keymanapp/kmc/build/src/commands/build.js:67:18)
    at async Command.parseAsync (/usr/local/lib/node_modules/@keymanapp/kmc/node_modules/commander/lib/command.js:935:5)
    at async run (file:///usr/local/lib/node_modules/@keymanapp/kmc/build/src/kmc.js:40:5)
    at async file:///usr/local/lib/node_modules/@keymanapp/kmc/build/src/kmc.js:14:5

file in question is https://raw.githubusercontent.com/unicode-org/cldr/keyboard-preview/keyboards/3.0/fr-t-k0-azerty.xml
@srl295 srl295 changed the title visual-keyboard-compiler throwing instead of callbacks 🙀 bug(developer): visual-keyboard-compiler throwing instead of callbacks 🙀 Aug 8, 2023
@mcdurdin mcdurdin mentioned this issue Aug 9, 2023
Merged
@srl295 srl295 added this to the A17S22 milestone Aug 18, 2023
@srl295 srl295 self-assigned this Aug 18, 2023
@mcdurdin mcdurdin modified the milestones: A17S22, A17S23 Oct 1, 2023
@mcdurdin mcdurdin modified the milestones: A17S23, A17S24 Oct 15, 2023
@mcdurdin mcdurdin modified the milestones: A17S24, A17S25 Oct 27, 2023
srl295 added a commit that referenced this issue Nov 10, 2023
@srl295
fix(developer): vis kbd callbacks instead of throw 🙀
1763e6a 
- fix API and call sites

For: #9438
@srl295 srl295 mentioned this issue Nov 10, 2023
Merged
srl295 added a commit that referenced this issue Nov 11, 2023
@srl295
fix(developer): dx: don't call exit(0) on failure 🙀
d06a423 
- always use std::exit(EXIT_FAILURE) if there is an error.

For: #9438
@mcdurdin mcdurdin modified the milestones: A17S25, A17S26 Nov 13, 2023
srl295 added a commit that referenced this issue Nov 16, 2023
@srl295
fix(developer): vis kbd callbacks instead of throw 🙀
361c7d8 
- fix API and call sites

For: #9438
srl295 added a commit that referenced this issue Nov 17, 2023
@srl295
feat(developer): ldml fix call to LdmlKeyboardVisualKeyboardCompiler() 🙀
b802d14 
- fix a call site

For: #9438
srl295 added a commit that referenced this issue Nov 17, 2023
@srl295
fix(developer): vis kbd callbacks instead of throw 🙀
fffac67 
- fix API and call sites

For: #9438
@srl295 srl295 linked a pull request Nov 25, 2023 that will close this issue
fix(developer): vis kbd callbacks instead of throw 🙀 #9979
Merged
@srl295
Copy link
Member Author

srl295 commented Nov 25, 2023

fixed in #9979

@srl295 srl295 closed this as completed Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
bug developer/compilers/ developer/ epic-ldml
Projects
None yet
Milestone
A17S26
Development

Successfully merging a pull request may close this issue.

fix(developer): vis kbd callbacks instead of throw 🙀 keymanapp/keyman
2 participants
@srl295 @mcdurdin