Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): tertiary reorders 🙀 #9707

Closed
srl295 opened this issue Oct 7, 2023 · 0 comments · Fixed by #9962
Closed

feat(core): tertiary reorders 🙀 #9707

srl295 opened this issue Oct 7, 2023 · 0 comments · Fixed by #9962
Assignees
@srl295
Labels
core/ Keyman Core epic-ldml feat
Milestone
A17S26

Comments

@srl295
Copy link
Member

srl295 commented Oct 7, 2023

@srl295 srl295 added this to the A17S23 milestone Oct 7, 2023
@srl295 srl295 self-assigned this Oct 7, 2023
@keymanapp-test-bot keymanapp-test-bot bot added core/ Keyman Core feat labels Oct 7, 2023
@srl295 srl295 mentioned this issue Oct 7, 2023
Closed
4 tasks
@mcdurdin mcdurdin modified the milestones: A17S23, A17S24, A17S25 Oct 15, 2023
srl295 added a commit that referenced this issue Oct 31, 2023
@srl295
feat(common): ldml update to WIP cldr data 🙀
f00e0e3 
- bn-bengali with a basic test
- fr-optimise
- note: disabling bengali reorders for now, not working properly due to tertiary reordering feat(core): tertiary reorders 🙀  #9707

For: #9916
@srl295 srl295 mentioned this issue Oct 31, 2023
Merged
srl295 added a commit that referenced this issue Nov 2, 2023
@srl295
feat(common): ldml update to WIP cldr data 🙀
09411eb 
- bn-bengali with a basic test
- fr-optimise
- note: disabling bengali reorders for now, not working properly due to tertiary reordering feat(core): tertiary reorders 🙀  #9707

For: #9916
srl295 added a commit that referenced this issue Nov 7, 2023
@srl295
feat(core): ldml tertiary reorder 🙀
8d16498 
- failing test cases, hooray! In XML and C++

For: #9707
srl295 added a commit that referenced this issue Nov 8, 2023
@srl295
feat(core): ldml tertiary reorder 🙀
0da4c35 
- implemented tertiary reordering
- reinstated bengali reordering!
- fixed reordering to be longest-first (by sorting the list before applying)
- updated debug logging

Fixes: #9707
@srl295 srl295 mentioned this issue Nov 8, 2023
Merged
@srl295 srl295 linked a pull request Nov 8, 2023 that will close this issue
feat(core): ldml tertiary reordering 🙀 #9962
Merged
srl295 added a commit that referenced this issue Nov 8, 2023
@srl295
feat(core): ldml tertiary reorder 🙀
beb54bf 
- fix an uninitialized field

Fixes: #9707
@mcdurdin mcdurdin modified the milestones: A17S25, A17S26 Nov 13, 2023
srl295 added a commit that referenced this issue Nov 16, 2023
@srl295
feat(core): ldml tertiary reorder 🙀
85a5afa 
- failing test cases, hooray! In XML and C++

For: #9707
srl295 added a commit that referenced this issue Nov 16, 2023
@srl295
feat(core): ldml tertiary reorder 🙀
f7566c7 
- implemented tertiary reordering
- reinstated bengali reordering!
- fixed reordering to be longest-first (by sorting the list before applying)
- updated debug logging

Fixes: #9707
srl295 added a commit that referenced this issue Nov 16, 2023
@srl295
feat(core): ldml dx: launch ldml unit tests before keyboard tests 🙀
30d951e 
For: #9707
srl295 added a commit that referenced this issue Nov 16, 2023
@srl295
feat(core): ldml tertiary reorder 🙀
3cd6c76 
- handle case where there's no tertiary base before the first char
- separate some element API tests from the actual tertiary test.  Tests were failing because of now-correct implementation.

Fixes: #9707
srl295 added a commit that referenced this issue Nov 16, 2023
@srl295
feat(core): ldml typedef for reorder weights 🙀
350eb83 
For: #9707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
core/ Keyman Core epic-ldml feat
Projects
None yet
Milestone
A17S26
Development

Successfully merging a pull request may close this issue.

feat(core): ldml tertiary reordering 🙀 keymanapp/keyman
2 participants
@srl295 @mcdurdin