Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(core): ldml don't require startContext 🙀 #9961

Closed
srl295 opened this issue Nov 7, 2023 · 0 comments · Fixed by #10021
Closed

bug(core): ldml don't require startContext 🙀 #9961

srl295 opened this issue Nov 7, 2023 · 0 comments · Fixed by #10021
Assignees
@srl295
Labels
bug core/ Keyman Core
Milestone
A17S26

Comments

@srl295
Copy link
Member

srl295 commented Nov 7, 2023

the compilation / LDML test runner crashes if you don't have at least:

<startContext to="" />
…

the runner (or compiler) should just default to an empty context if none is provided.
@srl295 srl295 added this to the A17S26 milestone Nov 7, 2023
@srl295 srl295 self-assigned this Nov 7, 2023
@mcdurdin mcdurdin changed the title fix(core): ldml don't require startContext 🙀 bug(core): ldml don't require startContext 🙀 Nov 7, 2023
@keymanapp-test-bot keymanapp-test-bot bot added bug core/ Keyman Core labels Nov 7, 2023
srl295 added a commit that referenced this issue Nov 16, 2023
@srl295
fix(core): dx: ldml: startContext should be optional in ldml test data 🙀
6bc72ff 
- per spec
- update tests to remove these

Fixes: #9961
@srl295 srl295 mentioned this issue Nov 16, 2023
Merged
@srl295 srl295 linked a pull request Nov 17, 2023 that will close this issue
fix(core): dx: ldml: startContext should be optional in ldml test data 🙀 #10021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
bug core/ Keyman Core
Projects
None yet
Milestone
A17S26
Development

Successfully merging a pull request may close this issue.

fix(core): dx: ldml: startContext should be optional in ldml test data 🙀 keymanapp/keyman
1 participant
@srl295