-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge master into epic/linux-mcompile #10076
Merged
mcdurdin
merged 232 commits into
epic/linux-mcompile
from
chore/merge-master-into-epic/linux-mcompile
Nov 24, 2023
Merged
chore: merge master into epic/linux-mcompile #10076
mcdurdin
merged 232 commits into
epic/linux-mcompile
from
chore/merge-master-into-epic/linux-mcompile
Nov 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toggle from suggestion to image banner
…/android/image-banner
…/android/image-banner
This change adds additional checks for the symbols file: - if a line with a method name gets changed, the package version number in that line also needs to be updated - for major API changes (methods renamed or removed) the API version numbers needs to be incremented - the API version numbers in the .symbols file and in `CORE_API_VERSION.md` need to match
* meson 1.2.3 is now available on choco * emscripten 3.1.40 is currently latest available choco version
…/android/image-banner
Relates to #9948. Starts basic support for v2.0 projects. For all operating modes: - Remove blank projects / untitled projects mode - Add Open Project Folder buttons and links - Remove Project Save As - Render uses in-memory XML - Upgrade to v2.0 project file (along with checks) For v2.0 projects: - Remove 'Add File to Project' - Populate Files to list all files in folder (note: consider efficiency here as currently files are parsed for subfile data) - Version 2.0 project options and defaults
Fixes #9869. Adds a 'Description' field, tweaks Copyright strings, and tweaks default content for documentation to the New Project wizards and kmconvert.
The caption on the spacebar used to be 60%. This change increases it to 100%, but that might be sometimes too big. On the other hand, 80% still seemed to be too small. Fixes #7940.
keyman-server
requested review from
sgschantz and
darcywong00
as code owners
November 24, 2023 00:30
github-actions
bot
added
web/
windows/
android/
developer/
ios/
linux/
common/
developer/compilers/
common/resources/
Build infrastructure
oem/
android/engine/
android/app/
ios/app/
ios/engine/
core/
Keyman Core
common/web/
developer/ide/
oem/fv/
oem/fv/android/
oem/fv/ios/
windows/config/
windows/engine/
docs
ios/samples/
chore
labels
Nov 24, 2023
mcdurdin
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android/app/
android/engine/
android/
chore
common/resources/
Build infrastructure
common/web/
common/
core/
Keyman Core
developer/compilers/
developer/ide/
developer/
docs
ios/app/
ios/engine/
ios/samples/
ios/
linux/
oem/fv/android/
oem/fv/ios/
oem/fv/
oem/
web/
windows/config/
windows/engine/
windows/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip