fix(core): clear core context on invalidate cache #10230
Conversation
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Test k_000___null_keyboard has been updated as the [RALT K_B] should cause the context to be reset. Test k_008___vkey_input__ctrl_alt_2_ has been updated as the [LCTRL LALT K_B] does not match a keyboard rule the context is deemed invalid and should be reset. It could be a consideration to modify the text_store object to better reflect the state of a applications context however this would mean we would need two expected results one for the application and one for the context
keymanapp-test-bot
bot
removed
the
user-test-missing
The unit tests needed to be updated to handle the cases where the context is invalidated by a keystroke. However, they still need to be able to verify the final string the application should recieve. To do this a expected context token has been added to the unit test format.
|
The unit tests needed to be updated to handle the cases Question for @ermshiperete and @sgschantz I updated this so that the existing unit tests did not need the |
|
I think making |
fix(mac): unit tests should expect core context clear after invalidate
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
rc-swag
dismissed
mcdurdin’s stale review
I have addressed the review comments - reviewer is on leave and was happy for someone else to review in his absence
|
Changes in this pull request will be available for download in Keyman version 17.0.233-alpha |
Fixes: #10182
The core context cache belonging to the state object is now cleared when the keyboard processor determines the context needs to be invalidated.
Test k_000___null_keyboard has been updated as the [RALT K_B] should
cause the context to be reset.
Test k_008___vkey_input__ctrl_alt_2_ has been updated as the [LCTRL LALT
K_B] does not match a keyboard rule the context is deemed invalid and should be
reset.
It could be a consideration to modify the text_store object to better
reflect the state of an application context however, this would mean
we would need two expected results one for the application and one
for the context.
@keymanapp-test-bot skip
Only skipping because the Windows and Linux builds can't be used to test as they currently still use the actions list and clear the core context cache. MacOS is probably is probably there?