fix(web): android-webview emulation Web test page missing initialKeyboard function
#10238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
|
For user-testing, shouldn't the web/src/test/manual/embed/index.html test page work with this PR? |
mcdurdin
approved these changes
Dec 13, 2023
I mean, that's the entire focus of this PR, so... yeah, we could do one if you feel it's necessary. |
Co-authored-by: Marc Durdin <marc@durdin.net>
mcdurdin
changed the title
initialKeyboard function
|
Changes in this pull request will be available for download in Keyman version 17.0.230-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10022 broke Web's test page that emulates an Android WebView, as it added a new method to the interface (in Android code) that did not get a mocked version in the test page. This rectifies that.
@keymanapp-test-bot skip