refactor(core): prepare normalization code to call into JS under WASM 🙀 #11519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alize.cpp - fold ldml_utils.hpp into core_icu.h - refactor to use km::core::util::normalize_nfd() functions where simple to do so For #9467
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
May 24, 2024
…-devolve-regex-to-js-epic-ldml
srl295
changed the title
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
6 similar comments
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
|
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor normalization code so that normalization calls go through the util_normalize module instead of directly into ICU.
This is in preparation for moving non-test callers from ICU to JS on wasm.
For: #9467
@keymanapp-test-bot skip