epic: improve model encoding compression 💾 #12293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion Aims for a UCS-2 encoded string and does not shy away from unpaired surrogates in the encoding.
… code When a leaf node exists at the same Trie location as an internal node, it should be a child of that internal node using SENTINEL_CODE_UNIT (\ufdd0). The fixture was using null/undefined instead!
… for compressed-Trie code
…on/models/templates We'll likely want to dynamically build a Trie to represent user-specific entries made available by the active OS. We'll then blend _that_ with the 'static' distributed model.
… improved encapsulation
…ruction' into refactor/common/models/trie-construction-cntd
…ruction-cntd' into change/common/models/trie-construction-cleanup
…ie-construction-cleanup' into feat/common/models/templates/trie-compression-start
…r's Trie, TrieModel
…n/models/templates/trie-compression-start
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
removed
the
user-test-missing
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
…/trie-compression-start feat(common/models): add Trie string-encoding + decoding methods 💾
…/integrate-trie-compression feat(common/models): integrate new trie decoding methods into predictive-text engine 💾
…iled-tries feat(developer): output new TrieModel format when compiling 💾
|
TODO:
|
…l-encoding chore: merge master into model-encoding
…l-encoding chore: merge master into model-encoding 💾
…l-encoding chore: merge master into model-encoding 💾
…l-encoding chore: merge master into model-encoding 💾
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip