-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Add device Settings link to KeymanSettingsActivity #12405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User tests have not been completed
labels
Sep 12, 2024
User Test ResultsTest specification and instructions Test Artifacts |
mcdurdin
approved these changes
Sep 12, 2024
keymanapp-test-bot
bot
removed
the
user-test-required
User tests have not been completed
label
Sep 13, 2024
Back to draft to resolve the scenario @dinakaranr found |
I'll abandon this and make an issue. There's some design that will need to happen because the normal Keyman initialization happens in MainActivity or SystemKeyboard. If Android is uninitialized, going through the Android settings link straight to the KeymanSettingsActivity results in things being uninitialized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While configuring test steps for #12381, I noticed the Android "General Management" settings had a link to keyboard settings for the current default keyboard.
This adds a link from the Android settings to the Keyman settings activity
User Testing
Setup - Install the PR build of Keyman for Android on a physical device. Enable Keyman as a system keyboard, but don't set to default yet.