fix(developer): handle missing files in kmc-kmn #12595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a file is not found, the loadfile callback now returns an empty array rather than null, which kmcmplib interprets as a missing file. This means a zero-byte file will have the same outcome but as it is also generally invalid, I think that is acceptable. Fixes: #12546 Fixes: KEYMAN-DEVELOPER-292
User Test ResultsTest specification and instructions User tests are not required |
|
Changes in this pull request will be available for download in Keyman version 18.0.135-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file is not found, the loadfile callback now returns an empty array rather than null, which kmcmplib interprets as a missing file. This means a zero-byte file will have the same outcome but as it is also generally invalid, I think that is acceptable.
The 17.0 compiler has a different callback mechanism, so won't cherry-pick to 17.0.
Fixes: #12546
Fixes: KEYMAN-DEVELOPER-292
@keymanapp-test-bot skip