Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): move web engine help to app repo #12601

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mcdurdin
Copy link
Member

Note: build.sh updated to make sure that test:help build action:target doesn't also call test.sh by adding :_all meta-target.

Note: CI will need a new help-keyman-com.sh build step to deploy web engine help.

Fixes: #12347

@keymanapp-test-bot skip

Note: build.sh updated to make sure that test:help build action:target
doesn't also call test.sh by adding `:_all` meta-target.

Note: CI will need a new help-keyman-com.sh build step to deploy web
engine help.

Fixes: #12347
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from refactor/windows/12347-move-engine-windows-into-app-repo to master November 5, 2024 06:06
@mcdurdin mcdurdin merged commit a233e4b into master Nov 5, 2024
29 checks passed
@mcdurdin mcdurdin deleted the refactor/web/12347-move-engine-web-into-app-repo branch November 5, 2024 06:06
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.135-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

refactor(developer): move help content for /developer/<version> from help.keyman.com to keyman repo
3 participants