Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): create Server config directory before options save 🍒 🏠 #12609

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Nov 4, 2024

Also use back-off logic for saving in case config file is locked by another process.

Cherry-pick-of: #12608
Fixes: #12607
Fixes: KEYMAN-DEVELOPER-1Z1

@keymanapp-test-bot skip

Also use back-off logic for saving in case config file is locked by
another process.

Cherry-pick-of: #12608
Fixes: #12607
Fixes: KEYMAN-DEVELOPER-1Z1
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 4, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(developer): create Server config directory before options save 🍒 fix(developer): create Server config directory before options save 🍒 🏠 Nov 4, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S14 milestone Nov 4, 2024
@github-actions github-actions bot added developer/ developer/ide/ cherry-pick Change already merged into another (stable) branch fix labels Nov 4, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit cab7cb5 into stable-17.0 Nov 5, 2024
5 checks passed
@mcdurdin mcdurdin deleted the fix/developer/cherry-pick/12607-force-server-directory-before-config-save branch November 5, 2024 06:05
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick Change already merged into another (stable) branch developer/ide/ developer/ fix stable
Projects
Status: Done
3 participants