fix(linux): set environment variable for rendering of downloads dialog 🍒 🏠 #12617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around a problem in webkit2gtk where the download dialog sometimes only renders a blank screen. Setting the environment variable seems to help, not only in the cases that the issue describes (with a NVidia graphics card), but also in my testing in a VM. Fixes: #12587 Cherry-pick-of: #12616
keymanapp-test-bot
bot
added
has-user-test
user-test-required
github-actions
bot
added
linux/
linux/config/
and removed
user-test-required
User Test ResultsTest specification and instructions Test Artifacts |
keymanapp-test-bot
bot
changed the title
ermshiperete
changed the title
keymanapp-test-bot
bot
added
the
user-test-required
mcdurdin
approved these changes
Nov 4, 2024
Test ResultsI tested this issue with the attached "package version 17.0.332-1~PR-12617-3958.1+noble1" build on the Noble & Focal OS environment. I'm sharing my observation here.
|
keymanapp-test-bot
bot
removed
the
user-test-required
|
Changes in this pull request will be available for download in Keyman version 17.0.332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a problem in webkit2gtk where the download dialog sometimes only renders a blank screen. Setting the environment variable seems to help, not only in the cases that the issue describes (with a NVidia graphics card), but also in my testing in a VM.
Fixes: #12587
Cherry-pick-of: #12616
User Testing
TEST_DOWNLOAD_PAGE: Open Keyman Config and click on the Download Keyboard button. The Download Keyman Keyboards page should show up.